Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Google Auth #1127

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

feat: Implement Google Auth #1127

wants to merge 21 commits into from

Conversation

alexespejo
Copy link
Contributor

@alexespejo alexespejo commented Jan 17, 2025

Summary

Updates to saving schedules

  • Signing in with Google or guest creates sessions, users, and accounts where the schedules will connect to
  • Save button should prompt the user to sign in with Google or as a guest
  • Guest accounts will have similar functionality to the current save/load logic where anyone could hypothetically override each other's schedules if they have the same name

Creating an account with existing schedules

Test Plan

  • Make sure users with old schedules can still access them
  • Ensure Google auth creates and persists sessions with schedules
  • Ensure Guest auth creates and persists sessions with schedules
  • All Guest accounts have to have a unique name (no duplicate Guests can be created)
  • Import schedule should not be affected
  • Create schedule before creating an acocunt (schedule should persist into the newly created account)
  • Sessions should expire after 7 days, expired sessions no errors should be thrown and schedule data shouldn't appear after expire
  • Data schedule data should not appear after sign out

Issues

Closes #

Tasks

  • Setup Google auth provider
  • Setup tRCP endpoint for handling Google
  • Wireup Sessions and auth
  • Build out sign in sign out UI and logic
  • Connect Schedules
  • Setup Guest login
  • Remove the ID from save alerts
  • Pain
  • Add email column to user
  • Guests are all unique (I forgot about this)
  • Cache existing schedule to local storage

Post Working Example

  • Configure secrets for prod and dev
  • Clean up 🍝 code
  • Programmatically connect redirect uri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant