Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tim/autosave roadmap import #573

Merged
merged 10 commits into from
Jan 31, 2025
Merged

Tim/autosave roadmap import #573

merged 10 commits into from
Jan 31, 2025
+14 −14

Conversation

timobraz
Copy link
Contributor

@timobraz timobraz commented Jan 28, 2025 •
edited
Loading

Description

When importing an account from Zot4Plan, it now saves any unsaved changes prior to the import. This prevents loss of progress. The button now also says "Import and Save" instead of just "Import".

Test Plan

  • Open staging instance
  • Go to your roadmap (should work both being logged in or not)
  • Make some change to the roadmap such as adding classes.
  • Don't save them
  • Import a Zot4Plan user.
  • Notice that the changes have been saved and persist

Issues

Closes #549

@timobraz timobraz temporarily deployed to staging-573 January 28, 2025 09:44 — with GitHub Actions Inactive
@timobraz timobraz requested a review from Awesome-E January 28, 2025 23:58
@timobraz timobraz marked this pull request as ready for review January 28, 2025 23:58
Awesome-E
Awesome-E reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the lint warning

site/src/pages/RoadmapPage/RoadmapMultiplan.tsx Outdated Show resolved Hide resolved
@timobraz timobraz temporarily deployed to staging-573 January 30, 2025 09:27 — with GitHub Actions Inactive
@timobraz timobraz requested a review from Awesome-E January 30, 2025 09:27
@timobraz timobraz temporarily deployed to staging-573 January 30, 2025 09:28 — with GitHub Actions Inactive
@timobraz timobraz temporarily deployed to staging-573 January 31, 2025 02:10 — with GitHub Actions Inactive
@timobraz timobraz requested a review from Awesome-E January 31, 2025 02:12
Awesome-E
Awesome-E approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now!

@timobraz timobraz temporarily deployed to staging-573 January 31, 2025 02:43 — with GitHub Actions Inactive
@timobraz timobraz merged commit 221ad2a into main Jan 31, 2025
2 checks passed
@timobraz timobraz deleted the tim/autosave-roadmap-import branch January 31, 2025 02:44
@Awesome-E Awesome-E linked an issue Jan 31, 2025 that may be closed by this pull request
Zot4Plan Migration Pipeline #521
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awesome-E Awesome-E Awesome-E approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically save PeterPortal roadmap when a Zot4Plan schedule is imported Zot4Plan Migration Pipeline
2 participants
@timobraz @Awesome-E