Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ICTSC2022 問題解説まとめ から ICTSC2019 本選 問題解説まとめ までのリンクを WordPress 側に寄せた #7

Merged
merged 4 commits into from
May 1, 2023
Merged

fix: ICTSC2022 問題解説まとめ から ICTSC2019 本選 問題解説まとめ までのリンクを WordPress 側に寄せた #7

merged 4 commits into from
May 1, 2023

Conversation

K-shir0
Copy link
Member

@K-shir0 K-shir0 commented Apr 25, 2023 •
edited
Loading

関連 #5

XX

  • ICTSC2019 二次予選 問題解説まとめ 以前は別途
  • restyled の空白修正が多くなってるので差分で見ていただけると🙏

@K-shir0 K-shir0 requested review from onokatio and x86taka April 25, 2023 21:22
@K-shir0 K-shir0 self-assigned this Apr 25, 2023
@restyled-io restyled-io bot mentioned this pull request Apr 25, 2023
Merged
@K-shir0
Merge pull request #8 from ictsc/restyled/hotfix/flug
52298ef 
Restyle fix: `ICTSC2022 問題解説まとめ` から `ICTSC2019 本選 問題解説まとめ` までのリンクを WordPress 側に寄せた
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 25, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 52298ef
Status: ✅  Deploy successful!
Preview URL: https://b38b574c.ictsc-tech-blog.pages.dev
Branch Preview URL: https://hotfix-flug.ictsc-tech-blog.pages.dev

View logs

x86taka
x86taka approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@x86taka x86taka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなりました、修正ありがとうございます！
問題ないように思います。

別で1点このprのbranch previewページで、各問題解説ページに飛ぶと https://blog.icttoracon.net/の公開済みの方に飛ばされてしまっていて、確認が大変になっているので改善できたらしたいですね。

@onokatio
Copy link
Member

onokatio commented May 1, 2023

全部相対リンクにすればいいのかな

@K-shir0
Copy link
Member Author

K-shir0 commented May 1, 2023

@K-shir0 K-shir0 merged commit c3bff85 into main May 1, 2023
@K-shir0 K-shir0 deleted the hotfix/flug branch May 1, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x86taka x86taka x86taka approved these changes

@onokatio onokatio Awaiting requested review from onokatio

Assignees

@K-shir0 K-shir0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@K-shir0 @onokatio @x86taka @restyled-commits