Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prominent link to coverage report #273

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented Oct 27, 2021

Refs #272

@dschwen dschwen requested a review from bwspenc October 27, 2021 16:34
@moosebuild
Copy link

moosebuild commented Oct 27, 2021

Job Test on 88d6c3f wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

moosebuild commented Oct 27, 2021

Job Coverage on 88d6c3f wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

@bwspenc
Copy link
Collaborator

bwspenc commented Oct 27, 2021

That is very prominent indeed. My first thought was that this might be a little too prominent. We should put this in a consistent place for all the apps or it won't be very helpful. Maybe this should go under some sort of developer resources page like the software coding standards page?

@loganharbour
Copy link
Member

I like the idea of something consistent. Although, apps do have different navigation so it may be difficult

@@ -25,6 +25,7 @@ Extensions:
Code Reference:
Systems: syntax/index.md
Software Quality: /sqa/index.md
Code Coverage: https://mooseframework.inl.gov/blackbear/docs/coverage/
Copy link
Collaborator

@bwspenc bwspenc Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our discussion, let's change line 25 to Documentation:, and add a new line after line 26 with Development:, so that the SQA and code coverage pages are under a new Development tab.

@bwspenc bwspenc merged commit fa19339 into idaholab:devel Dec 4, 2021
@bwspenc
Copy link
Collaborator

bwspenc commented Dec 4, 2021

I need to remember to make this same change for Grizzly and Bison...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants