Skip to content

Commit

Permalink
Fix memory leaks in harmonizer UTs (ydb-platform#13560)
Browse files Browse the repository at this point in the history
  • Loading branch information
serbel324 authored Jan 20, 2025
1 parent 4ac43ab commit c23916f
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions ydb/library/actors/core/harmonizer/ut/harmonizer_ut.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -281,23 +281,20 @@ Y_UNIT_TEST_SUITE(HarmonizerTests) {

Y_UNIT_TEST(TestHarmonize) {
ui64 currentTs = 1000000;
auto harmonizer = MakeHarmonizer(currentTs);
auto mockPool = new TMockExecutorPool();
harmonizer->AddPool(mockPool);
std::unique_ptr<IHarmonizer> harmonizer(MakeHarmonizer(currentTs));
std::unique_ptr<TMockExecutorPool> mockPool(new TMockExecutorPool);
harmonizer->AddPool(mockPool.get());

harmonizer->Harmonize(currentTs + 1000000); // 1 second later

auto stats = harmonizer->GetPoolStats(0);
Y_UNUSED(stats);
UNIT_ASSERT_VALUES_EQUAL(mockPool->ThreadCount, 4); // Should start with default

delete harmonizer;
delete mockPool;
}

Y_UNIT_TEST(TestToNeedyNextToHoggish) {
ui64 currentTs = 1000000;
auto harmonizer = MakeHarmonizer(currentTs);
std::unique_ptr<IHarmonizer> harmonizer(MakeHarmonizer(currentTs));
TMockExecutorPoolParams params;
std::vector<std::unique_ptr<TMockExecutorPool>> mockPools;
mockPools.emplace_back(new TMockExecutorPool(params));
Expand Down Expand Up @@ -338,7 +335,7 @@ Y_UNIT_TEST_SUITE(HarmonizerTests) {

Y_UNIT_TEST(TestToNeedyNextToStarved) {
ui64 currentTs = 1000000;
auto harmonizer = MakeHarmonizer(currentTs);
std::unique_ptr<IHarmonizer> harmonizer(MakeHarmonizer(currentTs));
TMockExecutorPoolParams params;
std::vector<std::unique_ptr<TMockExecutorPool>> mockPools;
mockPools.emplace_back(new TMockExecutorPool(params));
Expand Down Expand Up @@ -380,7 +377,7 @@ Y_UNIT_TEST_SUITE(HarmonizerTests) {

Y_UNIT_TEST(TestExchangeThreads) {
ui64 currentTs = 1000000;
auto harmonizer = MakeHarmonizer(currentTs);
std::unique_ptr<IHarmonizer> harmonizer(MakeHarmonizer(currentTs));
TMockExecutorPoolParams params {
.DefaultFullThreadCount = 1,
.MinFullThreadCount = 1,
Expand Down Expand Up @@ -475,7 +472,7 @@ Y_UNIT_TEST_SUITE(HarmonizerTests) {
.PoolId = 2,
},
};
auto harmonizer = MakeHarmonizer(currentTs);
std::unique_ptr<IHarmonizer> harmonizer(MakeHarmonizer(currentTs));
std::vector<std::unique_ptr<TMockExecutorPool>> mockPools;
i16 budget = 0;
for (auto& param : params) {
Expand Down

0 comments on commit c23916f

Please sign in to comment.