Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cki/GitHub workflow #3

Merged
merged 13 commits into from
Mar 10, 2025
Merged

Cki/GitHub workflow #3

merged 13 commits into from
Mar 10, 2025

Conversation

colemanirby
Copy link
Contributor

This PR closes out Issue #2. The code now must have the proper formatting in order to complete the build. As of right now, there is only 6% code coverage provided by tests so the build will not fail if the code coverage is below the minimum threshold of 70%. In the future, the minimum should be raised to 80% and builds should fail if they do not meet this requirement.

@colemanirby colemanirby requested a review from carloskiron March 4, 2025 17:09
Copy link
Contributor

@carloskiron carloskiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colemanirby looking good man!

@colemanirby colemanirby merged commit 9ef45b8 into main Mar 10, 2025
1 check passed
@colemanirby colemanirby deleted the cki/github-workflow branch March 10, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants