Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: construct call with response data #15

Merged
merged 30 commits into from
Oct 10, 2024

Conversation

juangirini
Copy link
Contributor

@juangirini juangirini commented Oct 9, 2024

closes ideal-lab5/murmur#17

companion for ideal-lab5/murmur#18

  • remove the constructExtrinsic function that was prone to errors
  • constructs the calls with the response data from the API

Copy link
Contributor

@driemworks driemworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juangirini juangirini merged commit d8d93e0 into main Oct 10, 2024
1 check passed
@juangirini juangirini deleted the feat/17-refactor-create-prepare-execute branch October 14, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[REFACTOR] create and prepare_execute to return building values
2 participants