Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chores(basic):simplify domain code #707

Merged
merged 17 commits into from
Apr 24, 2024
Merged

chores(basic):simplify domain code #707

merged 17 commits into from
Apr 24, 2024

Conversation

RWDai
Copy link
Contributor

@RWDai RWDai commented Apr 11, 2024

No description provided.

@RWDai RWDai requested a review from gudaoxuri April 11, 2024 09:45
@RWDai
Copy link
Contributor Author

RWDai commented Apr 11, 2024

@gudaoxuri pr终于实装了TardisCreateEntity宏，但是和原来的代码还有如下区别:
update_time不再兼容mysql的"ON UPDATE CURRENT_TIMESTAMP".
对两种数据库时间类型的区别不再由代码运行时决定而是通过feature 编译时决定

@RWDai RWDai marked this pull request as ready for review April 11, 2024 09:51
gudaoxuri
gudaoxuri reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@gudaoxuri gudaoxuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#TODO

  • 同步替换iam/reach等模块的domain,并确保单元测试通过；
  • 升级tardis版本到最新并更新bios的依赖。

@RWDai RWDai marked this pull request as draft April 11, 2024 10:16
@RWDai RWDai self-assigned this Apr 11, 2024
@RWDai RWDai marked this pull request as ready for review April 16, 2024 07:59
@gudaoxuri gudaoxuri merged commit 5d9724e into ideal-world:main Apr 24, 2024
2 checks passed
@RWDai RWDai deleted the chores(basic)-simplify-domain-code branch April 28, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gudaoxuri gudaoxuri gudaoxuri left review comments

Assignees

@RWDai RWDai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RWDai @gudaoxuri