fix invalid json schema (required field)
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-yle
force-pushed
the
kh/invalid-schema
branch
from
6fea81b to
20e8a60
Compare
|
What so the best way to test this (before/after)? |
|
The simplest method would be to paste the current schemas into a json schema validator, or checkout PR #173 and see the errors in your IDE: 
|
|
Tested the old vs new file with https://www.jsonschemavalidator.net/ and the errors go away:
|
tordans
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required: trueisn't valid, it needs to berequired: ["my field name", ...]