Skip to content

Commit

Permalink
feat: create a message for authenticate buf for generate ts-client (b…
Browse files Browse the repository at this point in the history
…ackport #4322) (#4332)

* feat: create a message for authenticate buf for generate ts-client (#4322)

* create a message for authenticate buf for generate ts-client

* add changelog

* upgrade msg

(cherry picked from commit 7ff4b5d)

# Conflicts:
#	ignite/cmd/generate_typescript_client.go

* Update changelog.md

* fix merge conflicts

---------

Co-authored-by: Danilo Pantani <[email protected]>
  • Loading branch information
mergify[bot] and Pantani authored Aug 30, 2024
1 parent 9287363 commit d0b7a39
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

- [#4319](https://github.com/ignite/cli/pull/4319) Remove fee abstraction module from open api code generation
- [#4309](https://github.com/ignite/cli/pull/4309) Fix chain id for chain simulations
- [#4322](https://github.com/ignite/cli/pull/4322) Create a message for authenticate buf for generate ts-client

### Fixes

Expand Down
10 changes: 10 additions & 0 deletions ignite/cmd/generate_typescript_client.go
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
package ignitecmd

import (
"github.com/manifoldco/promptui"
"github.com/spf13/cobra"

"github.com/ignite/cli/v28/ignite/pkg/cliui"
"github.com/ignite/cli/v28/ignite/pkg/cliui/icons"
"github.com/ignite/cli/v28/ignite/pkg/errors"
"github.com/ignite/cli/v28/ignite/services/chain"
)

const (
flagUseCache = "use-cache"
msgBufAuth = "Generate ts-client depends on a 'buf.build' remote plugin, and as of August 1, 2024, Buf will begin limiting remote plugin requests from unauthenticated users on 'buf.build'. If you send more than ten unauthenticated requests per hour using remote plugins, you’ll start to see rate limit errors. Please authenticate before running ts-client command using 'buf registry login' command and follow the instructions. For more info, check https://buf.build/docs/generate/auth-required."
)

func NewGenerateTSClient() *cobra.Command {
Expand Down Expand Up @@ -48,6 +51,13 @@ func generateTSClientHandler(cmd *cobra.Command, _ []string) error {
session := cliui.New(cliui.StartSpinnerWithText(statusGenerating))
defer session.End()

if err := session.AskConfirm(msgBufAuth); err != nil {
if errors.Is(err, promptui.ErrAbort) {
return errors.New("buf not auth")
}
return err
}

c, err := chain.NewWithHomeFlags(
cmd,
chain.WithOutputer(session),
Expand Down
2 changes: 2 additions & 0 deletions integration/cosmosgen/cosmosgen_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import (
)

func TestCosmosGenScaffold(t *testing.T) {
t.Skip("skip till we add a buf token into the CI")

var (
env = envtest.New(t)
app = env.Scaffold("github.com/test/blog")
Expand Down

0 comments on commit d0b7a39

Please sign in to comment.