fix: avoid create duplicated scopedKeppers (backport #4216) #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* avoid create duplicated scopedKeppers * add changelog (cherry picked from commit 6c22a43)
mergify
bot
requested review from
ilgooz,
salmad3,
toschdev,
jeronimoalbi,
Pantani and
julienrbrt
as code owners
github-actions
bot
added
component:ci
Pantani
approved these changes
Jun 27, 2024
julienrbrt
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4066
Description
Since we are not using the module keeper as a pointer, the scoped keeper can't be saved inside the keeper structure, causing chain crashes. This PR makes the App handle the scoped keeper logic.
This is an automatic backport of pull request #4216 done by Mergify.