fix: default flag parser for apps #4483
Merged
+38
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:ci
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
Pantani
changed the title
salmad3
approved these changes
Jan 31, 2025
julienrbrt
approved these changes
Feb 1, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2025
* fix default flag parse for apps * remove bug condition * fix. unit tests * add changelog --------- Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 7f91423) # Conflicts: # ignite/services/plugin/flag_test.go # ignite/services/plugin/grpc/v1/interface_flag.go
julienrbrt
added a commit
that referenced
this pull request
Feb 3, 2025
* fix: default flag parser for apps (#4483) * fix default flag parse for apps * remove bug condition * fix. unit tests * add changelog --------- Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 7f91423) # Conflicts: # ignite/services/plugin/flag_test.go # ignite/services/plugin/grpc/v1/interface_flag.go * fix merge conflicts * Update changelog.md --------- Co-authored-by: Danilo Pantani <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix default values for app flags, it always gets zero if the value is not set