Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set address prefix with sdk v0.52 #4486

Merged
merged 4 commits into from
Jan 31, 2025
Merged

fix: set address prefix with sdk v0.52 #4486

merged 4 commits into from
Jan 31, 2025

Conversation

Senna46
Copy link
Contributor

@Senna46 Senna46 commented Jan 31, 2025 •
edited by julienrbrt
Loading

Cosmos SDK v0.52 does not allow configuration changes when the Config is sealed.
SetConfigAddressPrefix function cannot be excuted after the Config is set, but instead must be used WithAddressPrefix in client.Context.

Closes: #2744

@Senna46 Senna46 changed the title fix: cosmos client v0.52 fix: set address bprefix with sdk v0.52 Jan 31, 2025
@Senna46 Senna46 changed the title fix: set address bprefix with sdk v0.52 fix: set address prefix with sdk v0.52 Jan 31, 2025
julienrbrt
julienrbrt previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right! Thanks for this.

@julienrbrt
Copy link
Member

Could you add a changelog under unreleased ## Changes?

@Senna46
Copy link
Contributor Author

Senna46 commented Jan 31, 2025

OK
I add changelog under unreleased ## Changes

@Senna46 Senna46 mentioned this pull request Jan 31, 2025
Open
@julienrbrt julienrbrt merged commit 8a382f9 into ignite:main Jan 31, 2025
42 of 45 checks passed
@Senna46 Senna46 mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@Senna46 Senna46

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UPDATE: improve account prefix management for txs in cosmosclient
2 participants
@Senna46 @julienrbrt