Adjust message for formerly "live" videos #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holta
reviewed
Jul 5, 2024
holta
reviewed
Jul 5, 2024
cps/tasks/download.py
Outdated
| @@ -54,6 +56,9 @@ def run(self, worker_thread): | |||
| last_progress_time = datetime.now() | |||
| fragment_stuck_timeout = 30 # seconds | |||
|
|
|||
| self.message = f"Downloading {self.media_url_link}..." | |||
| if self.live_status == "was_live": | |||
| self.message += f" (This may take longer than expected due to the video was live for {self.duration})" | |||
There was a problem hiding this comment.
Do we dare abbreviate the message to something like... ?
Suggested change
| self.message += f" (This may take longer than expected due to the video was live for {self.duration})" | |
| self.message += f" (formerly live video, length/duration is {self.duration} seconds)" |
Co-authored-by: A Holt <[email protected]>
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display a message to let the user know about potential long download when a formerly live video is requested.
Tested on Ubuntu 24.04 (LRN2)
