Updated dependencies #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
force-pushed
the
update-dependencies
branch
from
a513e27 to
edbb822
Compare
ijlee2
commented
Dec 27, 2024
Comment on lines
+11
to
+32
| /* | ||
| If your v2 addons need to support `[email protected]`, | ||
| please update your `blueprints-v2-addon` to use | ||
| `@glimmer/[email protected]`. | ||
|
|
||
| Otherwise, you can delete this scenario. | ||
| */ | ||
| // { | ||
| // name: 'ember-lts-3.28', | ||
| // npm: { | ||
| // devDependencies: { | ||
| // '@ember/test-helpers': '2.9.4', | ||
| // '@types/ember__test-helpers': '2.9.1', | ||
| // '@types/ember-qunit': '6.1.1', | ||
| // 'ember-a11y-testing': '5.2.1', | ||
| // 'ember-cli': '~3.28.0', | ||
| // 'ember-qunit': '6.0.0', | ||
| // 'ember-resolver': '11.0.1', | ||
| // 'ember-source': '~3.28.0', | ||
| // }, | ||
| // }, | ||
| // }, |
There was a problem hiding this comment.
@glimmer/[email protected] dropped support for ember-source<4.10 so this ember-try scenario fails out of the box if we try to create a Glimmer component (w/ an empty class and template) in a v2 addon.
Could not find module `@ember/owner` imported from `my-addon`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
[email protected])ember-source@<4.10(due to@glimmer/[email protected]).