Fixed silent fail on player name change #391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #387
Error description taken from here: https://open.mp/docs/scripting/functions/SetPlayerName
Changed to InvalidOperationException as you requested, I agree with that.
I revised all the other calls into SAMP and return codes, seems no more checks like this one are needed.
I ignored the return codes for "Player not exists", "Vehicle not exists", "Object not exists", and so on... because if those are destroyed then the SampSharp instance for that entity will be disposed.
And also I ignored the parameters check errors, because I think we should add own checks in SampSharp to throw descriptive and specific errors. SAMP is returning only one error code for different situations.
PS: sorry for creating new PR (the old one is #388), I messed up the old fork 😅