Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search 2 #75

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Feature/search 2 #75

merged 6 commits into from
Sep 2, 2024

Conversation

Romstone
Copy link
Collaborator

No description provided.

@Romstone Romstone requested a review from iliubinskii as a code owner August 28, 2024 18:44
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
zero-company-app ⬜️ Ignored (Inspect) Sep 2, 2024 6:02am

@iliubinskii
Copy link
Owner

  1. Please add "use client"

image

  1. Try to move autoMode and loading states to . Split fetchMoreData function for that.

  2. Try to take initial value here from query (q=...):

const [searchInput, setSearchInput] = useState("");
  1. Instead of checking e.key === "Enter", try to use form onSubmit event (don't forget e.preventDefault)

  2. If there no results, show a notice saying that no results are found

@iliubinskii iliubinskii merged commit 37adfdb into develop Sep 2, 2024
6 checks passed
@iliubinskii iliubinskii deleted the feature/search-2 branch September 2, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants