-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make compatible with non-coupling-enabled versions of grudge v3 #1048
Conversation
f6849d1
to
6bcca49
Compare
I don't have a problem with anything being done here, except the hamstringing of the prediction tests. If prediction tests can't be run, then nothing can stop us from checking things in that break prediction - which has caused us great trouble multiple times in the not-too-distant past. |
Just to clarify, this PR currently includes changing the |
Ah, I see now. So is the plan that external packages can do their "upstream mirgecom tests" in CI by using |
Yes, |
I don't think it can be "or". Upstream pkg's dowstream mirgecom tests should include the examples, at least, if not exclusively. |
This is ready for review. The Production CI error is due to a merge issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Followup of #898.
TODO:
needs Restore loop inference fallback inducer/arraycontext#269main
(undo 596894d)Questions for the review: