or_vs_and: silence some false positives

Sizeof(something) ends up being a literal. So you'd think it would "sizeof(foo)" it is "4" or whatever. And then two literals happen to be the same value and you end up with false positives. Signed-off-by: Dan Carpenter <[email protected]>
illumos · Jan 9, 2024 · aaedaf5 · aaedaf5
1 parent 86bb869
commit aaedaf5
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/check_or_vs_and.c b/check_or_vs_and.c
@@ -32,8 +32,14 @@ static int does_inc_dec(struct expression *expr)
 
 static int expr_equiv_no_inc_dec(struct expression *one, struct expression *two)
 {
+	sval_t dummy;
+
 	if (does_inc_dec(one) || does_inc_dec(two))
 		return 0;
+	if (get_value(one, &dummy) &&
+	    get_value(two, &dummy))
+		return 0;
+
 	return expr_equiv(one, two);
 }