-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Refactor #97
Open
iloveicedgreentea
wants to merge
96
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Merge Refactor #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major rewrite that completely changes how it works internally. It also makes it easier to extend to other plays via home assistant so theoretically any media_player entity can work (apple tv, kodi, etc). The kodi integration already exposes the necessary data. I have a custom_component for Plex coming soon, and Jellyfin support might be simple to add.
I use an Event abstraction so any received payload can be a "webhook". It uses a media player abstraction with common functions to support pretty much any player through "backends" which are either home assistant or plex webhooks. Technically speaking any player can have a native implementation too its just duplicative of home assistant. It just needs to implement the media player interface.
Because each major component uses abstractions it is now very easy to extend functionality if I ever want to. For example, I could reintroduce actions like controlling physical devices but at the moment theres no reason to duplicate what home assistant does.
SQLite is used to persist configs
I also redid the UI to use modern React with shadcn, tailwind, etc
Some things are not yet supported like HDMI sync that will take more time but I do have it working locally.
Lots of changes...
Im not a frontend dev but this is scalable and easy to work with