-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Float64 Support #59
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 79.89% 80.51% +0.62%
==========================================
Files 12 12
Lines 562 580 +18
Branches 110 113 +3
==========================================
+ Hits 449 467 +18
Misses 106 106
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Thanks! Why can't you attach an image ? Is it because of their size? We need at least one for the test cases. |
Maybe we can use this library to generate a test image. |
Sorry, github didn't allow uploading .TIFF files but simply zipping it solves this problem. Attached is a float64 .TIFF file I used for testing. |
Can you add one to the img folder and update the test to include it here? |
The image and test have been added successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
This PR adds
float64
support for decoding.tiff
files. This is in reference to issue #58.The changes are relatively minor. This has been tested and works. I can't attach an example file here, but the data provided here is
float64
Geodatenviewer der Stadt Wien.Additionally, since I have been testing this locally, I used
npm pack
to make the module available locally to me. I added.tgz
files to the.gitignore
, but this change is not strictly necessary.