List mirrors of updates sites right after the original site #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order that update sites matter when multiple update sites provide the same files. This is how the Java-8 update site overwrites files provided by the ImageJ and Fiji update sites. At the moment, the ImageJ, Fiji, and Java-8 mirror site are listed after the original. If someone selects the ImageJ and Fiji mirrors but not the Java-8 mirror, then the Java-8 overwrite is replaced by the mirrors. To avoid this, this commit moves the ImageJ and Fiji update sites under the original update site. See https://forum.image.sc/t/errors-with-european-mirrors-for-fiji-and-imagej/103355
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/errors-with-european-mirrors-for-fiji-and-imagej/103355/2 |
|
@carandraug Good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order that update sites matter when multiple update sites provide the same files. This is how the Java-8 update site overwrites files provided by the ImageJ and Fiji update sites.
At the moment, the ImageJ, Fiji, and Java-8 mirror site are listed after the original. If someone selects the ImageJ and Fiji mirrors but not the Java-8 mirror, then the Java-8 overwrite is replaced by the mirrors. To avoid this, this commit moves the ImageJ and Fiji update sites under the original update site. See
https://forum.image.sc/t/errors-with-european-mirrors-for-fiji-and-imagej/103355
I didn't actually check in the code how the updater chooses files, I'm guessing that's how it does it from the behaviour.