Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a maven-projects example for accessing image metadata #45

Merged
merged 2 commits into from
Nov 30, 2017
Merged

Added a maven-projects example for accessing image metadata #45

merged 2 commits into from
Nov 30, 2017

Conversation

brossetti
Copy link
Contributor

I've added a maven-projects example for printing image metadata (based on issue #35). I understand that this example is not in line with the effort to unify the tutorials as notebooks (issue #30), but I think this example is still of value to aspiring plugin programmers.

Copy link
Member

@imagejan imagejan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks a lot for your contribution. I added a few minor comments below. Maybe we can name the class GetMetadata instead of PrintMetadata, as we're not printing anything here? The others may have better suggestions...

<parent>
<groupId>org.scijava</groupId>
<artifactId>pom-scijava</artifactId>
<version>16.1.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

17.1.1 at the time of writing.


<groupId>imagej-tutorials</groupId>
<artifactId>metadata</artifactId>
<version>1.0.0-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather take 0.1.0-SNAPSHOT as a starting point for development when taking this tutorial as a template.

<name>Metadata</name>
<description>This example shows how to access and print metadata with SCIFIO.</description>
<url>https://github.com/[MY-ORG]/[MY-REPO]</url>
<inceptionYear>2013</inceptionYear>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 2017? 😄

<dependency>
<groupId>io.scif</groupId>
<artifactId>scifio-bf-compat</artifactId>
<scope>runtime</scope>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting went wrong here.

* An optional {@code formatMetadata} method is included to (hopefully) make the text more readable.
* </p>
*/
@Plugin(type = Command.class, menuPath = "Plugins>Print Metadata")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid cluttering the Plugins menu even more, we should try to encourage people to use more specific sub-menus, or put this in Image>Show Metadata next to the Properties... and Show Info commands.


}

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing line break at end of file.

@brossetti brossetti changed the title Added a maven-projects example for printing image metadata Added a maven-projects example for accessing image metadata Oct 30, 2017
@ctrueden
Copy link
Member

ctrueden commented Nov 30, 2017

Sorry for the delay! I noticed this again just now. Thanks for the contribution. 👍

I guess we should merge all the SCIFIO tutorials to this repository? What do you think @imagejan @brossetti ? Or if we don't merge them, would it make more sense to put this new tutorial in the SCIFIO tutorials instead?

@ctrueden
Copy link
Member

For now I'll merge and add this tutorial here. But we certainly want to have a coherent strategy for what goes where in the long term.

@ctrueden ctrueden merged commit 50ae7ac into imagej:master Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants