Fix rpc signature error

javascript/package.json

@@ -1,6 +1,6 @@
 {
   "name": "imjoy-rpc",
-  "version": "0.5.47",
+  "version": "0.5.48",
   "description": "Remote procedure calls for ImJoy.",
   "module": "index.js",
   "types": "index.d.ts",

javascript/src/hypha/rpc.js

@@ -1236,7 +1236,11 @@ export class RPC extends MessageEmitter {
       };
     } else if (aObject instanceof Error) {
       console.error(aObject);
-      bObject = { _rtype: "error", _rvalue: aObject.toString() };
+      bObject = {
+        _rtype: "error",
+        _rvalue: aObject.toString(),
+        _rtrace: aObject.stack
+      };
     }
     // send objects supported by structure clone algorithm
     // https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm
@@ -1405,7 +1409,9 @@ export class RPC extends MessageEmitter {
           bObject = aObject;
         }
       } else if (aObject._rtype === "error") {
-        bObject = new Error(aObject._rvalue);
+        bObject = new Error(
+          "RemoteError: " + aObject._rvalue + "\n" + (aObject._rtrace || "")
+        );
       } else if (aObject._rtype === "typedarray") {
         const arraytype = dtypeToTypedArray[aObject._rdtype];
         if (!arraytype)

python/.gitignore

@@ -1,6 +1,6 @@
 
 .vscode
-
+.pypirc
 *.DS_Store
 *.app
 node_modules

python/imjoy_rpc/VERSION

@@ -1,3 +1,3 @@
 {
-    "version": "0.5.47"
+    "version": "0.5.48"
 }

python/imjoy_rpc/hypha/rpc.py

@@ -77,6 +77,12 @@ def index_object(obj, ids):
         return index_object(_obj, ids[1:])
 
 
+class RemoteException(Exception):
+    """Represent a remote exception."""
+
+    pass
+
+
 class Timer:
     """Represent a timer."""
 
@@ -817,12 +823,17 @@ def handle_result(fut):
         remote_method.__rpc_object__ = (
             encoded_method.copy()
         )  # pylint: disable=protected-access
-        make_signature(
-            remote_method,
-            name=method_id.split(".")[-1],
-            doc=encoded_method.get("_rdoc"),
-            sig=encoded_method.get("_rsig"),
-        )
+        try:
+            make_signature(
+                remote_method,
+                name=method_id.split(".")[-1],
+                doc=encoded_method.get("_rdoc"),
+                sig=encoded_method.get("_rsig"),
+            )
+        except Exception as exp:
+            logger.warning(
+                "Failed to generate signature for method: %s, error: %s", method_id, exp
+            )
         return remote_method
 
     def _log(self, info):
@@ -1193,7 +1204,16 @@ def _encode(
             }
 
         elif isinstance(a_object, Exception):
-            b_object = {"_rtype": "error", "_rvalue": str(a_object)}
+            exc_traceback = "".join(
+                traceback.format_exception(
+                    etype=type(a_object), value=a_object, tb=a_object.__traceback__
+                )
+            )
+            b_object = {
+                "_rtype": "error",
+                "_rvalue": str(a_object),
+                "_rtrace": exc_traceback,
+            }
         elif isinstance(a_object, memoryview):
             b_object = {"_rtype": "memoryview", "_rvalue": a_object.tobytes()}
         elif isinstance(
@@ -1364,7 +1384,12 @@ def _decode(
                     )
                 )
             elif a_object["_rtype"] == "error":
-                b_object = Exception(a_object["_rvalue"])
+                b_object = RemoteException(
+                    "RemoteError:"
+                    + a_object["_rvalue"]
+                    + "\n"
+                    + (a_object.get("_rtrace") if a_object.get("_rtrace") else "")
+                )
             else:
                 # make sure all the interface functions are decoded
                 temp = a_object["_rtype"]

python/imjoy_rpc/utils.py

@@ -908,20 +908,24 @@ def elfinder_listdir(path):
         req = _sync_xhr_get(url)
         if req.status in [200, 206]:
             file_list = json.loads(req.response.to_py().tobytes().decode())
-            if 'list' in file_list:
-                return file_list['list']
+            if "list" in file_list:
+                return file_list["list"]
             else:
                 return []
         else:
-            raise FileNotFoundError(f"Directory '{path}' could not be found, HTTP status code: {req.status}")
+            raise FileNotFoundError(
+                f"Directory '{path}' could not be found, HTTP status code: {req.status}"
+            )
     else:
         req = Request(url)
         response = urlopen(req)
         if response.getcode() == 200:
             file_list = json.loads(response.read().decode())
-            if 'list' in file_list:
-                return file_list['list']
+            if "list" in file_list:
+                return file_list["list"]
             else:
                 return []
         else:
-            raise FileNotFoundError(f"Directory '{path}' could not be found, HTTP status code: {response.getcode()}")
+            raise FileNotFoundError(
+                f"Directory '{path}' could not be found, HTTP status code: {response.getcode()}"
+            )