Events to promises #104
Merged
Events to promises #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecified action circumstances.
|
The language needs to be updated to be more in line with other specs but we can make that change later. |
cabanier
approved these changes
Dec 23, 2024
github-actions bot
added a commit
that referenced
this pull request
Dec 23, 2024
SHA: 1bac4fc Reason: push, by zachernuk Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion today (which was in agreement with earlier conversations about this) - If there's a reason to go with Events instead here I'm happy to go with it, but AFAICT the author-controlled aspects of asset loading are a decent fit with Promises.