Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warning instead of error for invalid icc when decoding jpeg #138

Merged
merged 3 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions server/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,14 @@ RUN ./configure-apt.sh && \
apt-get remove -yqq jq wget ca-certificates && \
apt-get autoremove -yqq && \
apt-get clean && \
dpkg -r --force-depends libjpeg62-turbo && \
rm -rf \
configure-apt.sh \
install-ffmpeg.sh \
*.deb \
/var/lib/apt/lists
/var/lib/apt/lists \
/usr/lib/$(arch)-linux-gnu/libjpeg.so* \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to remove libjpeg?
Sharp does not use by default the decoder from /usr/local/lib?

root@03fa65ee8b06:/# ldd /usr/local/bin/vips | grep jpeg
        libjpeg.so.8 => /usr/local/lib/libjpeg.so.8 (0x000014f26b39f000)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes the image smaller and avoids any ambiguity.

/usr/share/doc/libjpeg62-turbo \
/usr/share/lintian/overrides/libjpeg62-turbo

COPY --from=dev /usr/local/lib/ /usr/local/lib/
COPY --from=dev /build/geodata/ /build/geodata/
Expand Down
1 change: 1 addition & 0 deletions server/bin/build-libjxl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ cd libjxl
git reset --hard "$LIBJXL_REVISION"
git submodule update --init --recursive --depth 1 --recommend-shallow
git apply ../jpegli-empty-dht-marker.patch # adapted from https://github.com/libjxl/libjxl/pull/2704
git apply ../jpegli-icc-warning.patch

mkdir build
cd build
Expand Down
39 changes: 39 additions & 0 deletions server/bin/patches/jpegli-icc-warning.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
diff --git a/lib/jpegli/decode_marker.cc b/lib/jpegli/decode_marker.cc
index 2621ed08..33cbb8be 100644
--- a/lib/jpegli/decode_marker.cc
+++ b/lib/jpegli/decode_marker.cc
@@ -408,24 +408,29 @@ void ProcessAPP(j_decompress_ptr cinfo, const uint8_t* data, size_t len) {
payload += sizeof(kIccProfileTag);
payload_size -= sizeof(kIccProfileTag);
if (payload_size < 2) {
- JPEGLI_ERROR("ICC chunk is too small.");
+ JPEGLI_WARN("ICC chunk is too small.");
+ return;
}
uint8_t index = payload[0];
uint8_t total = payload[1];
++m->icc_index_;
if (m->icc_index_ != index) {
- JPEGLI_ERROR("Invalid ICC chunk order.");
+ JPEGLI_WARN("Invalid ICC chunk order.");
+ return;
}
if (total == 0) {
- JPEGLI_ERROR("Invalid ICC chunk total.");
+ JPEGLI_WARN("Invalid ICC chunk total.");
+ return;
}
if (m->icc_total_ == 0) {
m->icc_total_ = total;
} else if (m->icc_total_ != total) {
- JPEGLI_ERROR("Invalid ICC chunk total.");
+ JPEGLI_WARN("Invalid ICC chunk total.");
+ return;
}
if (m->icc_index_ > m->icc_total_) {
- JPEGLI_ERROR("Invalid ICC chunk index.");
+ JPEGLI_WARN("Invalid ICC chunk index.");
+ return;
}
m->icc_profile_.insert(m->icc_profile_.end(), payload + 2,
payload + payload_size);