Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): fix broken --album on Windows. #10626

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix(cli): fix broken --album on Windows. #10626

merged 1 commit into from
Jun 26, 2024

Conversation

fky2015
Copy link
Contributor

@fky2015 fky2015 commented Jun 25, 2024 •
edited
Loading

fix #10617

  • extract folder name with system functions for robustness. (with tests added)

@fky2015
fix(cli): fix broken --album on Windows.
b41de15 
Extract folder names via system function to avoid the difference between / and \ on Windows.
@github-actions github-actions bot added the cli Tasks related to the Immich CLI label Jun 25, 2024
bo0tzz
bo0tzz approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@waqasali101
Copy link

Amazing, thanks for prompt fix @fky2015

@alextran1502 alextran1502 merged commit a3c3619 into immich-app:main Jun 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo0tzz bo0tzz bo0tzz approved these changes

Assignees
No one assigned
Labels
cli Tasks related to the Immich CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Immich CLI add to album broken on windows
4 participants
@fky2015 @waqasali101 @bo0tzz @alextran1502