docs: add-hash #15860 follow-up

[NicholasFlamy]

Description

Adds hash to URL.
I forgot to do this in the original PR #15860. Sorry about that.

How Has This Been Tested?

• Tested in dev environment with npm run start for docs.

Screenshots (if appropriate)

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation if applicable
• I have no unrelated changes in the PR.
• I have confirmed that any new dependencies are strictly necessary.
• I have written tests for new code (if applicable)
• I have followed naming conventions/patterns in the surrounding code
• All code in src/services uses repositories implementations for database calls, filesystem operations, etc.
• All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services)

[bo0tzz]

Maybe instead of manual concatenation, use https://developer.mozilla.org/en-US/docs/Web/API/URL. I would expect that to handle all of these details.

[jrasm91]

new URL(location.href, url).href should do it I think

[NicholasFlamy]

new URL(location.href, url).href should do it I think

I'll have to test, but I'm not sure that will work based on the Mozilla docs: https://developer.mozilla.org/en-US/docs/Web/API/URL/URL

new URL(url, base)

If url is an absolute URL, a given base will not be used to create the resulting URL.

Edit: undo edit.

Edit 2: I don't see any easy way to do this as location.href returns the absolute URL. The won't work for new URL(url, base) because we need a relative reference, and that goes back to location.pathname + location.hash. Theoretically you could use location.pathname + location.hash inside new URL(url, base) but then you're just concatenating into it. Unless that constructor is somehow more optimized than a regular concatenation, I'm not sure what it would accomplish.