Update asset.ts - fix file path translation from Windows > Linux #9253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update your PR? The build fails and you have some strange changes in the imports etc (changed " to ') etc. Please fix the build errors :) |
…h-app#9265) This commit fixes the issues related to reassigning faces in the server and web components. It includes a fix for reassiging faces and a rename operation.
|
HI I believe I sorted the issues, but how do I test if the build is ok? I've tried to follow |
|
@Donovoi As a first time contributor, we will have to manually trigger the check run |
alextran1502
added
documentation
|
Sweet thank you! Let me know when you do and I'll fix up any issues 😁 |
|
You seem to have an extra dependency "install" that is not required, also the builds and tests are failing. Can you fix these two problems please? |
Update npm dependencies to the latest stable versions, including "install" and "upath". Co-authored-by: Tushar Harsora <[email protected]> Co-authored-by: Daniel Dietzler <[email protected]> Co-authored-by: Alex <[email protected]>
|
hopefully that's all done! |
zackpollard
reviewed
May 24, 2024
|
I think this has been superseded by #10430? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of my folders in Windows had special characters like "@" which were not being handled correctly and stopped everything else from being processed. This uses the library "upath" to fix the issue. I'm not a typescript developer so please let me know if I'm doing something incorrect.
Thank you