Log to addr when looping blocklist (#28)

immutable · Jan 23, 2025 · 4012e7c · 4012e7c
1 parent 759552c
commit 4012e7c
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 183 deletions.
diff --git a/core/txpool/immutable/accesscontrol/contract_creation_controller.go b/core/txpool/immutable/accesscontrol/contract_creation_controller.go
diff --git a/core/txpool/immutable/accesscontrol/contract_creation_controller_test.go b/core/txpool/immutable/accesscontrol/contract_creation_controller_test.go
diff --git a/core/txpool/immutable/accesscontrol/controller_test.go b/core/txpool/immutable/accesscontrol/controller_test.go
@@ -81,6 +81,19 @@ func TestImmutableAccessControl_Controller_IsAllowed(t *testing.T) {
 			addressToCheck:  common.HexToAddress("0xabcdefabcdefabcdefabcdefabcdefabcdefabcdefab"),
 			expectedAllowed: true,
 		},
+		{
+			name:          "AddressIsEmpty",
+			isAnAllowList: false,
+			providers: map[string]AddressProvider{
+				"list": &MockAddressProvider{
+					addresses: map[common.Address]struct{}{
+						common.HexToAddress("0x1234567890123456789012345678901234567890"): {},
+					},
+				},
+			},
+			addressToCheck:  common.Address{},
+			expectedAllowed: true,
+		},
 		{
 			name:          "AddressInAllowedAddresses",
 			isAnAllowList: true,

diff --git a/core/txpool/legacypool/legacypool.go b/core/txpool/legacypool/legacypool.go
@@ -324,7 +324,8 @@ func (pool *LegacyPool) FilterWithError(tx *types.Transaction) error {
 	// Check for every access controllers that this transaction is allowed to go through
 	for _, accessControl := range pool.accessControllers {
 		if !accessControl.IsAllowed(from, tx) {
-			log.Warn("Transaction is not allowed by access control", "from", from, "tx", tx.Hash(), "isBlockList", accessControl.IsBlocklist())
+			log.Warn("Transaction is not allowed by access control",
+				"from", from, "to", tx.To(), "tx", tx.Hash(), "isBlockList", accessControl.IsBlocklist())
 			// If any access control doesn't allow
 			return txpool.ErrTxIsUnauthorized
 		}