Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: align marketplace structure with unity (#3545 #3546 #3551) #167

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

ImmutableJeffrey
Copy link
Collaborator

Summary

  • Refactored the marketplace link generation functions to utilise structs for query parameters.
  • Alphabetised the on-ramp query parameters dictionary.
  • Added an additional argument extraQueryParams to GenerateOnRampLink so that developers can include more configurations. Developers can refer to the Transak documentation for further configuration fields.
  • Updated blueprints that demo this functionality

Other things to consider:

  • Prefix your PR title with feat: , fix: , chore: , docs: , refactor: or test: .
  • Sample blueprints are updated with new SDK changes
  • Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • Replied to GitHub issues

Sorry, something went wrong.

@ImmutableJeffrey ImmutableJeffrey requested a review from a team as a code owner January 28, 2025 22:29
@ImmutableJeffrey ImmutableJeffrey merged commit bc8fff2 into main Jan 29, 2025
11 checks passed
@ImmutableJeffrey ImmutableJeffrey deleted the feat/align-marketplace branch January 29, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants