[SMR-1996] RBAC refactor #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📃CI ReportCompiling 138 files with 0.8.19
For a full HTML report run: |
rzmahmood
reviewed
Nov 16, 2023
rzmahmood
reviewed
Nov 16, 2023
rzmahmood
reviewed
Nov 16, 2023
rzmahmood
reviewed
Nov 16, 2023
rzmahmood
reviewed
Nov 16, 2023
| ) | ||
| ); | ||
| mockBridgeRoles.pause(); | ||
| vm.stopPrank(); |
There was a problem hiding this comment.
no change required, but there is also changePrank(unpaused) should you ever desire
rzmahmood
reviewed
Nov 16, 2023
tsnewnami
commented
Nov 16, 2023
rzmahmood
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the implementation of RBAC to make it more standard by adding
BridgeRoles.solwhich is an abstract contract providing common role and pausable functionality that is shared across the root and child chain bridge contracts.