vision camera improvements for iOS #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can put something in error and return nil
from 550ms per frame to 120ms per frame on my iPhone 13 pro
add geo model result caching (saves about 5ms per frame)
LOL. did xcode pick this and autocomplete it from some other RN module?
kvangork
reviewed
Oct 24, 2024
ios/VisionCameraPluginInatVision/VisionCameraPluginInatVision.m
Outdated
Show resolved
Hide resolved
we can use the results object on our request after the handler has finished performing the request.
kvangork
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main improvements are to add on-device geo model for higher accuracy, and score pruning before tree walkup.
on my iPhone 13 Pro, we go from 550ms per frame to 120ms per frame, even including the geo model, by pruning scores.