Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Update Inventory model strategy #100

Conversation

rahulpatel596
Copy link
Contributor

@rahulpatel596 rahulpatel596 commented May 7, 2024

Update Inventory Model Strategy

Summary

This pull request updates the inventory model by adding a new strategy: split_by_line_items, introduced by Commerce Layer.

Details

Currently, this provider is being used in our project but does not accept the split_by_line_items value as a valid strategy in inventory model. This pull request adds split_by_line_items as an acceptable strategy value.

Commerce Layer Documentation: Inventory Strategies

@rahulpatel596 rahulpatel596 requested a review from a team as a code owner May 7, 2024 15:57
@rahulpatel596
Copy link
Contributor Author

@demeyerthom Sorry for the ping, Would it be possible to review this and merge it.

@demeyerthom
Copy link
Collaborator

@rahulpatel596 no problem, but I am currently not the maintainer of this package anymore.

@jobveldhuis @LuudJanssen mind taking a look?

@rahulpatel596
Copy link
Contributor Author

@demeyerthom Thank you so much :)
@jobveldhuis @LuudJanssen Would appreciate your help merging this one

@jobveldhuis
Copy link

Hey there, @rahulpatel596. I'll have a look at this later today!

@jobveldhuis jobveldhuis self-requested a review May 8, 2024 14:57
@jobveldhuis jobveldhuis self-assigned this May 8, 2024
@pamelazagatti
Copy link

@jobveldhuis Any update on this?

Copy link

@jobveldhuis jobveldhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took a bit longer than expected, due to other obligations, but looks good to me! Thanks for the PR!

@jobveldhuis jobveldhuis merged commit 41b6aae into incentro-ecx:main May 10, 2024
5 checks passed
@jobveldhuis
Copy link

I will draft a new release for this specific feature on monday.

@jobveldhuis
Copy link

I have just released version 0.0.18, which contains this addition.

@pamelazagatti
Copy link

@jobveldhuis it seems this version hasn't been deployed in terraform cloud yet as per the official site. Also, when I upgrade and run the plan command I get an error informing this version isn't available

image

image

Could you please look into it?
Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants