Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eleventy-plugin-sharp for image processing #46

Closed
greatislander opened this issue Aug 19, 2020 · 2 comments · Fixed by #90
Closed

Add eleventy-plugin-sharp for image processing #46

greatislander opened this issue Aug 19, 2020 · 2 comments · Fixed by #90
Assignees
@greatislander
Labels
enhancement New feature or request
Milestone
1.3.0

Comments

@greatislander
Copy link
Member

greatislander commented Aug 19, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

We should scaled down uploaded images to appropriate responsive sizes so that users don't have to manage multiple image sizes through the CMS.

Describe the solution you'd like

Add eleventy-plugin-sharp to the Eleventy configuration to handle image resizing.

Describe alternatives you've considered

Not applicable.

Additional context

@11ty/eleventy-img does not currently support cropping. eleventy-plugin-sharp involves more configuration via filters in templates but supports cropping and scaling.
@greatislander greatislander added the enhancement New feature or request label Aug 19, 2020
@greatislander greatislander added this to the 1.2.0 milestone Aug 19, 2020
@greatislander greatislander self-assigned this Aug 19, 2020
@greatislander greatislander modified the milestones: 1.2.0, 1.3.0 Aug 31, 2020
@rishhabh-jain
Copy link

Hey, I want to work on this issue. How can I do that

@greatislander greatislander changed the title Add @11ty/eleventy-img for image processing Add eleventy-plugin-sharp for image processing Sep 15, 2020
@greatislander
Copy link
Member Author

@rishhabh-jain thanks for your interest! However, this issue involves close collaboration within our team working on design and development and as such is not a good candidate for open source contributions. I will be adding the good first issue tags to issues where external contributions are encouraged.

@greatislander greatislander mentioned this issue Sep 17, 2020
Merged
3 tasks
greatislander added a commit that referenced this issue Sep 17, 2020
@greatislander
feat: add eleventy-plugin-sharp, process thumbnails for ideas (resolves
7a501dd 
#46) (#90)

* feat: integrate eleventy-plugin-sharp for ideas thumbs

* fix: adjust Lighthouse configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

feat: add eleventy-plugin-sharp, process thumbnails for ideas (resolves #46) inclusive-design/idrc
2 participants
@greatislander @rishhabh-jain