feat: add eleventy-plugin-sharp, process thumbnails for ideas (resolves #46) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatislander
changed the title
|
Deploy preview for idrc ready! Built with commit fa25016 |
Visual Regression Test Results❌ 5 scenarios failed, ✅ 13 scenarios passed Scenario Details❌ Home (phone) — Before / After (2.57% mismatch)❌ Home (tablet) — Before / After (3.94% mismatch) ✅ Home (desktop) — Before / After ✅ News (phone) — Before / After ✅ News (tablet) — Before / After ✅ News (desktop) — Before / After ❌ Ideas (phone) — Before / After (12.25% mismatch) ❌ Ideas (tablet) — Before / After (9.16% mismatch) ❌ Ideas (desktop) — Before / After (9.30% mismatch) ✅ Projects and tools (phone) — Before / After ✅ Projects and tools (tablet) — Before / After ✅ Projects and tools (desktop) — Before / After ✅ IDRC Consulting (phone) — Before / After ✅ IDRC Consulting (tablet) — Before / After ✅ IDRC Consulting (desktop) — Before / After ✅ Vision Technology Service (phone) — Before / After ✅ Vision Technology Service (tablet) — Before / After ✅ Vision Technology Service (desktop) — Before / After To review the full report with screenshots, visit the Github Actions page and download the backstop-report artifact. If these changes were intended, run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run testwithout errorsnpm run buildwithout errorsDescription
This PR integrates eleventy-plugin-sharp and implements thumbnail generation for the ideas page.
Steps to test
Expected behavior: Ideas have properly scaled thumbnails.
Additional information
Known issues: the shortcodes registered by this plugin are incompatible with our current preview mechanism. They also don't seem to work within partials at present. More to investigate.
Future enhancements: resize social images to match Open Graph recommendations.
Related issues
Resolves #46.