Refactor and shrink Entry
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may improve performance slightly, because it will perform a hash lookup only once, although `RawTable` does force an early reserve to accomplish that. This is the same trade-off that `insert` makes. This also lets us remove the saved key from `map::OccupiedEntry`, which may benefit all other `entry` use cases where that was unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entrywith more separation from therawpartreplace_fullmap::OccupiedEntry. That also shrinksEntrybecause there's now room for the enum tag in a layout niche, although such layout is not guaranteed.