Skip to content

Commit

Permalink
pyproject: bump min python to 3.10
Browse files Browse the repository at this point in the history
  • Loading branch information
alexfikl authored and inducer committed Nov 13, 2024
1 parent bc0bd4f commit fcd23e9
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 16 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ jobs:
curl -L -O https://tiker.net/ci-support-v0
. ./ci-support-v0
# NOTE: jax>=0.4.31 requires python 3.10 and uses pattern matching
# which conflicts with our mypy.python_version = '3.8' setting
CONDA_ENVIRONMENT=.test-conda-env-py3.yml
sed -i "s/jax/jax<0.4.31/" "$CONDA_ENVIRONMENT"
build_py_project_in_conda_env
python -m pip install mypy pytest
./run-mypy.sh
Expand Down
4 changes: 1 addition & 3 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,7 @@ Pylint:

Mypy:
script: |
# NOTE: jax>=0.4.31 requires python 3.10 and uses pattern matching
# which conflicts with our mypy.python_version = '3.8' setting
EXTRA_INSTALL="mypy pytest jax[cpu]<0.4.31"
EXTRA_INSTALL="mypy pytest"
curl -L -O https://tiker.net/ci-support-v0
. ./ci-support-v0
Expand Down
2 changes: 1 addition & 1 deletion arraycontext/container/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,14 @@
Protocol,
Sequence,
Tuple,
TypeAlias,
TypeVar,
)

# For use in singledispatch type annotations, because sphinx can't figure out
# what 'np' is.
import numpy
import numpy as np
from typing_extensions import TypeAlias

from arraycontext.context import ArrayContext

Expand Down
10 changes: 3 additions & 7 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ requires = [

[project]
name = "arraycontext"
version = "2021.1"
version = "2024.0"
description = "Choose your favorite numpy-workalike"
readme = "README.rst"
license = { text = "MIT" }
authors = [
{ name = "Andreas Kloeckner", email = "[email protected]" },
]
requires-python = ">=3.8"
requires-python = ">=3.10"
classifiers = [
"Development Status :: 3 - Alpha",
"Intended Audience :: Developers",
Expand All @@ -33,9 +33,6 @@ dependencies = [
"immutabledict>=4.1",
"numpy",
"pytools>=2024.1.3",

# for TypeAlias
"typing-extensions>=4; python_version<'3.10'",
]

[project.optional-dependencies]
Expand Down Expand Up @@ -122,8 +119,7 @@ known-local-folder = [
lines-after-imports = 2

[tool.mypy]
# TODO: unpin jax version on CI when this gets bumped to 3.10
python_version = "3.8"
python_version = "3.10"
warn_unused_ignores = true
# TODO: enable this
# check_untyped_defs = true
Expand Down

0 comments on commit fcd23e9

Please sign in to comment.