Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match numpy interface for empty reductions #136

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Match numpy interface for empty reductions #136

wants to merge 6 commits into from

Conversation

inducer
Copy link
Owner

@inducer inducer commented Dec 28, 2021 •
edited by majosm
Loading

cc @majosm @alexfikl

@inducer inducer mentioned this pull request Dec 28, 2021
Open
@inducer inducer force-pushed the reduction-empty-initial branch from 93b2816 to 07a2773 Compare December 28, 2021 14:37
@inducer inducer force-pushed the reduction-empty-initial branch 2 times, most recently from b7ff764 to c677cc9 Compare December 29, 2021 18:29
majosm
majosm reviewed Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@majosm majosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of things I was wondering about while attempting to add the PyOpenCL equivalents.

arraycontext/impl/pytato/fake_numpy.py Show resolved Hide resolved
arraycontext/impl/pytato/fake_numpy.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majosm majosm majosm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inducer @majosm