New loop nest constraints (newest nest-constraint PR, directly against main) #468

jdsteve2 · 2021-07-20T20:31:54Z

Specify and check must-nest and must-not-nest constraints on loop nestings.

Constraint specification and checking
Enforcement during linearization
Child PR covers processing of constraints during transformations: Handle new loop nest constraints during transformation

Older, out-of-date PRs with this content:

Original PR branching off dependency semantics stuff that includes enforcement of constraints during many (not all) transformations
Second PR made against @kaushikcfd's new scheduling stuff (PR against main was initially made by moving those commits here)

CC @kaushikcfd

…t-constraints-v2

…ch loop-nest-constraints-v2

…-nest-constraints-v2

…straints-v2

…t_nests(), get_graph_sources()

…m old loop-nest-constraints-v2 branch)

…ions

…s with a vec tag

jdsteve2 added 9 commits July 20, 2021 15:21

import constrain_loop_nesting

ad088a5

add loop_nest_constraints attribute to kernel

3a656c0

copy in classes to contain loop nest constraints from branch loop-nes…

c665327

…t-constraints-v2

copy in functions for initial loop nest constraint creation from bran…

6f080d2

…ch loop-nest-constraints-v2

copy in functions for checking loop nest constraints from branch loop…

33dd179

…-nest-constraints-v2

add tests for loop nest constraint creation from branch loop-nest-con…

63015f6

…straints-v2

fix typo in comment

90b84c3

add for_each_kernel decorator to constrain_loop_nesting

29c2617

fix bugs due to callables update

9dbba39

jdsteve2 marked this pull request as draft July 20, 2021 20:32

jdsteve2 changed the title ~~New loop nest constraints (newest PR, directly off main)~~ New loop nest constraints (newest PR, directly against main) Jul 20, 2021

This was referenced Jul 20, 2021

Add loop nest constraints v2 to better loop around nest map #360

Draft

Loop nest constraints #347

Closed

jdsteve2 added 11 commits July 20, 2021 15:50

change 'assert False' to 'raise AssertionError()'

51ede85

copy in funcs from loop-nest-constraints-v2 branch: check_all_must_no…

f04ca4b

…t_nests(), get_graph_sources()

enforce new loop nest constraints during linearization (copied in fro…

057f69b

…m old loop-nest-constraints-v2 branch)

test that nest constraints are enforced during linearization

9725335

raise AssertionError instead of asserting False

9a07784

clearer comments/code for handling nest constraints during linearization

ad8940b

remove unnecessary all_inames arg from nest constraint checking funct…

42a109a

…ions

eliminate mostly redundant function check_all_must_not_nests

d6bc3c0

more code cleanup

f7f8f2a

add a test that tries adding a must_not_nest constraint that conflict…

cd76f66

…s with a vec tag

Merge branch 'main' into new-loop-nest-constraints

67ca67c

jdsteve2 marked this pull request as ready for review July 23, 2021 23:06

jdsteve2 changed the title ~~New loop nest constraints (newest PR, directly against main)~~ New loop nest constraints (newest nest-constraint PR, directly against main) Jul 26, 2021

jdsteve2 mentioned this pull request Jul 27, 2021

(draft PR for comparison only) Compare old loop nest constraint branch to new branch #471

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New loop nest constraints (newest nest-constraint PR, directly against main) #468

New loop nest constraints (newest nest-constraint PR, directly against main) #468

jdsteve2 commented Jul 20, 2021 •

edited

Loading

New loop nest constraints (newest nest-constraint PR, directly against main) #468

Are you sure you want to change the base?

New loop nest constraints (newest nest-constraint PR, directly against main) #468

Conversation

jdsteve2 commented Jul 20, 2021 • edited Loading

jdsteve2 commented Jul 20, 2021 •

edited

Loading