Implement distributed layer potential evaluation #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
reviewed
Oct 9, 2023
Comment on lines
+41
to
+46
| global_traversal: Any | ||
| centers: Any | ||
| expansion_radii: Any | ||
| global_qbx_centers: Any | ||
| qbx_center_to_target_box: Any | ||
| non_qbx_box_target_lists: Any | ||
| center_to_tree_targets: Any |
There was a problem hiding this comment.
Eventually: improve type annotation
inducer
reviewed
Mar 25, 2024
pytential/qbx/distributed.py
Outdated
| fmm_backend=fmm_backend, | ||
| **kwargs) | ||
| else: | ||
| self._use_target_specific_qbx = _use_target_specific_qbx |
There was a problem hiding this comment.
Document that this is an internal code path for workers.
gaohao95
changed the title
gaohao95
commented
Aug 26, 2024
| @@ -8,7 +8,7 @@ git+https://github.com/inducer/modepy.git#egg=modepy | |||
| git+https://github.com/inducer/pyopencl.git#egg=pyopencl | |||
| git+https://github.com/inducer/islpy.git#egg=islpy | |||
| git+https://github.com/inducer/loopy.git#egg=loopy | |||
| git+https://github.com/inducer/boxtree.git#egg=boxtree | |||
| git+https://github.com/gaohao95/boxtree.git@dist-pytential#egg=boxtree | |||
There was a problem hiding this comment.
This needs to be reverted back after inducer/boxtree#93 lands.
|
#239 should get rid of the mypy problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the distributed layer potential evaluation using MPI. On the high level, it broadcasts the necessary geometry data from the root rank to the worker rank, and each worker rank constructs a local copy of the geometry data independently.
❗ Depends on inducer/boxtree#93.