Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject and ruff #230

Merged
merged 10 commits into from
Jul 5, 2024
Merged

Switch to pyproject and ruff #230

merged 10 commits into from
Jul 5, 2024

Conversation

alexfikl
Copy link
Collaborator

@alexfikl alexfikl commented Jul 4, 2024

This does the switch as for the other projects. I've tested that it still builds the sdist and wheel correctly with python -m build.

The only other thing that's changed is the removal of that _git_rev.py file. If I understood the logic correctly:

  • In a normal git editable install, it was being overwritten anyway.
  • In a tagged release sdist/wheel, it wouldn't matter because the full version is enough of an identifier.
  • In a non-release sdist/wheel, it would still be needed, since there's no git directory. Is this a valid usecase? Maybe we can use something standardized like setuptools-scm for that..

TODOs

@alexfikl alexfikl marked this pull request as draft July 4, 2024 16:48
@alexfikl alexfikl marked this pull request as ready for review July 4, 2024 16:51
pyproject.toml Show resolved Hide resolved
setup.py Show resolved Hide resolved
@alexfikl alexfikl marked this pull request as draft July 4, 2024 16:56
@alexfikl alexfikl marked this pull request as ready for review July 4, 2024 17:21
@alexfikl
Copy link
Collaborator Author

alexfikl commented Jul 5, 2024

@inducer Just re-ran the whole CI and it didn't crash, so not sure what that symengine failure was about :\

@inducer inducer merged commit 9520853 into inducer:main Jul 5, 2024
8 checks passed
@inducer
Copy link
Owner

inducer commented Jul 5, 2024

Thx!

@alexfikl alexfikl deleted the switch-ruff branch July 5, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants