-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject and ruff #230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
commented
Jul 4, 2024
alexfikl
commented
Jul 4, 2024
alexfikl
commented
Jul 4, 2024
@inducer Just re-ran the whole CI and it didn't crash, so not sure what that symengine failure was about :\ |
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the switch as for the other projects. I've tested that it still builds the sdist and wheel correctly with
python -m build
.The only other thing that's changed is the removal of that
_git_rev.py
file. If I understood the logic correctly:TODOs
memoize_in(Generic[P, R])
to justmemoize_in
. Not sure why that's suddenly an issue..python_version = "3.8"
for mypy (like it was originally insetup.cfg
). By default it uses the version of the interpreter (3.12 on the CI, I assume) and was unhappy about this for some reason..