Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to new pymbolic #242

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Conversation

alexfikl
Copy link
Collaborator

@alexfikl alexfikl commented Oct 8, 2024

Updates things to use expr_dataclass and fixes various deprecation warnings.

Needs:

@alexfikl
Copy link
Collaborator Author

alexfikl commented Oct 9, 2024

This seems to be in a better state than expected! The remaining deprecation warnings are from loopy and sumpy and it just need a little change in pymbolic for __eq__ in IntG to work.

@alexfikl alexfikl mentioned this pull request Oct 27, 2024
@alexfikl alexfikl force-pushed the port-pymbolic-dataclass branch 3 times, most recently from 1eee3ac to 623eb93 Compare November 13, 2024 07:28
@alexfikl alexfikl marked this pull request as ready for review November 13, 2024 08:14
@alexfikl
Copy link
Collaborator Author

@inducer This should be good for a look now that all the upstream changes are in.

@inducer
Copy link
Owner

inducer commented Nov 13, 2024

I have some changes based on inducer/pymbolic#159 that I'd like to push. I imagine you have some changes based on inducer/pymbolic#160 that you'd like to push. How do we sort them to avoid stomping on one another's feet?

@alexfikl
Copy link
Collaborator Author

alexfikl commented Nov 13, 2024

I have some changes based on inducer/pymbolic#159 that I'd like to push. I imagine you have some changes based on inducer/pymbolic#160 that you'd like to push. How do we sort them to avoid stomping on one another's feet?

I haven't actually started making any changes here based on inducer/pymbolic#160, so go right ahead with yours!

This will start complaining once inducer/pymbolic#160 is merged though 😁

@inducer inducer force-pushed the port-pymbolic-dataclass branch from 42a5cf8 to ec3bdc4 Compare November 13, 2024 19:31
@inducer
Copy link
Owner

inducer commented Nov 13, 2024

This will start complaining once inducer/pymbolic#160 is merged though 😁

Uh-oh. Better get this in quickly. :)

@inducer inducer force-pushed the port-pymbolic-dataclass branch 2 times, most recently from fdd934a to 707dec3 Compare November 13, 2024 19:36
@inducer inducer enabled auto-merge (rebase) November 13, 2024 19:37
@inducer inducer force-pushed the port-pymbolic-dataclass branch from 2140d25 to 579f0c2 Compare November 13, 2024 20:00
@inducer inducer merged commit be7dd77 into inducer:main Nov 13, 2024
9 checks passed
@alexfikl alexfikl deleted the port-pymbolic-dataclass branch November 13, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants