-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace __new__ componentwise #247
Conversation
bef9a2a
to
58c2112
Compare
Thanks! One thing that went through my head is whether we should outright deprecate direct constructor calls that bypass the factory functions. |
Implied but not said: how do you feel about that idea? |
Calling the constructor directly should still be ok for "internal" code though, right? e.g. all the mappers call the constructor directly. |
c7a184e
to
9f471cf
Compare
9f471cf
to
0a246a5
Compare
Yes, definitely. One question is whether we'll make them pass a flag to say, "I'm internal!" |
I don't know, I agree that we should discourage that somehow, but maybe a little blurb in the docs will do the trick? I'm mostly hesitant because: adding a little flag is annoying + none of the other expressions have a deprecated constructor. |
0a246a5
to
49e71b0
Compare
49e71b0
to
6946383
Compare
6946383
to
da71cdc
Compare
This is awesome. Thanks so much for doing this! |
Fixes #246.