-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stokes biharmonic #29
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 958d578.
When I print the expression you feed to
(Use |
Got it. Thanks. Is there a way to pass a constant to |
I meant passing |
I mean, you could create an |
pytential/symbolic/stokes.py
Outdated
from math import pi | ||
from pytential.symbolic.primitives import as_dofdesc, DEFAULT_SOURCE | ||
const = -3/(8*pi) * sym.integral(self.dim, self.dim-1, density, | ||
dofdesc=as_dofdesc(DEFAULT_SOURCE)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inducer, is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it looks that way. One remaining issue is that the Stokeslet is being passed a density with the mean removed. This mean also involves an integral that needs to be told where to evaluate. I'm suspecting there might be a way to make the ToTargetTagger
smarter to automatically tag things more appropriately.
:arg qbx_forced_limit: the *qbx_forced_limit* argument to be passed on | ||
to :class:`~pytential.symbolic.primitives.IntG`. | ||
""" | ||
return self.apply(density_vec_sym, qbx_forced_limit, [deriv_dir]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raise a DeprecationWarning
, remove from docs.
for j in range(i): | ||
self.kernel_dict[(i, j)] = self.kernel_dict[(j, i)] | ||
|
||
def get_int_g(self, idx, density_sym, dir_vec_sym, qbx_forced_limit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Underscore me.
:arg qbx_forced_limit: the *qbx_forced_limit* argument to be passed on | ||
to :class:`~pytential.symbolic.primitives.IntG`. | ||
""" | ||
raise NotImplementedError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are u_i
in these docstrings?
This reverts commit f3a1660.
# TargetPointMultiplier has to be the outermost kernel | ||
# If it is the inner kernel, return early | ||
if isinstance(knl, TargetPointMultiplier): | ||
return 1, int_g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return 1, int_g | |
return int_g |
?
e445b42
to
feec35e
Compare
Mirror of https://gitlab.tiker.net/inducer/pytential/-/merge_requests/163 for review