tag: only import typing_extensions when TYPE_CHECKING #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likely this mypy issue: python/mypy#14220 |
alexfikl
force-pushed
the
fix-upstream-mypy-errors
branch
from
1fafd16 to
9e80a1d
Compare
inducer
force-pushed
the
fix-upstream-mypy-errors
branch
from
b7c6487 to
08df0b2
Compare
inducer
force-pushed
the
fix-upstream-mypy-errors
branch
from
08df0b2 to
a2267ab
Compare
|
LGTM with minor fixes. Thanks! |
|
Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix the issues from inducer/arraycontext#275