Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jax from import #169

Open
wants to merge 3 commits into
base: v1.0.0_alpha
Choose a base branch
from
Open

Conversation

OzanCatalVerses
Copy link
Collaborator

si.py was still refering to the pymdp.jax.control version of control.py breaking imports of sophisticated inference. Also removes unused imports.

@OzanCatalVerses OzanCatalVerses marked this pull request as draft February 5, 2025 15:47
@tverbele tverbele marked this pull request as ready for review February 25, 2025 20:46
@tverbele
Copy link
Collaborator

Yup, good catch ...
@conorheins do we have a new equivalent of the old pymdp.maths.EPS_VAL instead of hard coding 1e-16?
We might also want to update the notebooks though...

@conorheins
Copy link
Collaborator

Yup, good catch ... @conorheins do we have a new equivalent of the old pymdp.maths.EPS_VAL instead of hard coding 1e-16? We might also want to update the notebooks though...

See my comment above on the policy entropy function -- we avoid evaluating log of 0.0 within the the stable_log function now, because that function clips the output to a tiny value determined by jnp.finfo(float).eps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants