-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten PDex IDs #40
Shorten PDex IDs #40
Conversation
You could also make sure no ids include |
Good idea, I will do this as well and then the long IDs hopefully will no longer be a problem at all |
ids, shorten tests imported from us core by removing us_core_v311 prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments. I think if we delete us_core_v311 prefix we should add pdex prefix to make sure nothing breaks downstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case everything looks good. Test Kit and RSpec still work. Thanks for spearheading this Emily!
Summary
Some PDex IDs are very long and make importing into other test kits exceed the character limit for IDs. Shortened some of the longest ones to make importing this test kit easier.