Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten PDex IDs #40

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Shorten PDex IDs #40

merged 4 commits into from
Feb 20, 2025

Conversation

emichaud998
Copy link
Contributor

@emichaud998 emichaud998 commented Feb 14, 2025

Summary

Some PDex IDs are very long and make importing into other test kits exceed the character limit for IDs. Shortened some of the longest ones to make importing this test kit easier.

@Jammjammjamm
Copy link
Contributor

You could also make sure no ids include _test or _group.

@emichaud998
Copy link
Contributor Author

You could also make sure no ids include _test or _group.

Good idea, I will do this as well and then the long IDs hopefully will no longer be a problem at all

ids, shorten tests imported from us core by removing us_core_v311 prefix
@emichaud998 emichaud998 changed the title Shorten PDex Server IDs Shorten PDex IDs Feb 14, 2025
Copy link
Contributor

@Shaumik-Ashraf Shaumik-Ashraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments. I think if we delete us_core_v311 prefix we should add pdex prefix to make sure nothing breaks downstream.

Copy link
Contributor

@Shaumik-Ashraf Shaumik-Ashraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case everything looks good. Test Kit and RSpec still work. Thanks for spearheading this Emily!

@emichaud998 emichaud998 merged commit eb4d006 into main Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants