FI-2947: Allow Some /metadata Requests to Fail #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emichaud998
changed the base branch from
main
to
FI-2945_Service_Base_URL_Refactor_Tests
emichaud998
changed the base branch from
FI-2945_Service_Base_URL_Refactor_Tests
to
FI-2946_Input_Limit_Endpoints
arscan
reviewed
Sep 6, 2024
lib/service_base_url_test_kit/service_base_url_validate_group.rb
Outdated
Show resolved
Hide resolved
arscan
reviewed
Sep 6, 2024
lib/service_base_url_test_kit/service_base_url_validate_group.rb
Outdated
Show resolved
Hide resolved
arscan
requested changes
Sep 6, 2024
There was a problem hiding this comment.
I think you'll need to fix that issue with the 'get' not being protected within the warning before this can go in.
One other minor thing besides the inline comments, with this in, we may want to just update the description of the 'availability limit' to say something like this first "In the case where the Endpoint Availability Success Rate is 'All', "
arscan
approved these changes
Sep 6, 2024
…and still pass the test
…ty limit description
emichaud998
force-pushed
the
FI-2947_Allow_Some_Metadata_Request_Failure
branch
from
b20a01a
to
3165e8d
Compare
emichaud998
added a commit
that referenced
this pull request
Sep 6, 2024
* Add input to allow user to select if some metadata requests can fail and still pass the test * Fix issue with get not being protected and update endpoint availability limit description
emichaud998
added a commit
that referenced
this pull request
Sep 6, 2024
* Add input to limit the numeber of endpoints that Inferno will check for availability * Remove line used for testing purposes * Clean up code and add additional info message * FI-2947: Allow Some /metadata Requests to Fail (#27) * Add input to allow user to select if some metadata requests can fail and still pass the test * Fix issue with get not being protected and update endpoint availability limit description * Fix problems after rebase * Fix spelling typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow for some endpoints to fail the /metadata request without failing the whole system. Some endpoint lists have so many endpoints that at any given time some might be down because they have been decommissioned since the list was published, and that isn't a sign of nonconformance on the publishers part. This PR adds an input that allows the user to select between 3 options for testing endpoint availability: