Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3754 Default suites to use smart v2.0.0 in new metadata #229

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

arscan
Copy link
Contributor

@arscan arscan commented Feb 14, 2025

inferno.healthit.gov defaults to smart v2 for all suites in US Core. See https://inferno.healthit.gov/test-kits/us-core/

This updates our suite options to be consistent with that so there is no behavior change when we migrate over to the new method of leveraging test kit metadata on platform apps.

This operates under the assumption that we want to use this version of smart as the default, but it seems reasonable to me. Feel free to disagree though -- we don't have to merge this.

This includes functionality provided by the new v0.6.4 inferno core release, which is why the gemspec reflects that as a minimum version.

The only way to test right now is to launch the app and check the API responses that come back; SMART App Launch 2 should be the default for all US Core suites. A later upgrade to inferno core will update the standalone app UI, but in the meantime we'll be updating platforms to read that so as to not loose existing functionality on inferno.healthit.gov in moving towards test kit metadata usage on the test kit pages.

Screenshot 2025-02-14 at 2 25 56 PM

@arscan arscan requested a review from Jammjammjamm February 14, 2025 04:35
Copy link
Contributor

@Jammjammjamm Jammjammjamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation for the JSON API will need to be updated to reflect this.

Also, a boolean on the individual options is not the way we set defaults for radio inputs, where we set the default value on the field. It seems strange to use a different convention here.

@arscan
Copy link
Contributor Author

arscan commented Feb 14, 2025

Oh, I didn't realize 2 things:

  1. this was a feature we put into the jekyll platform templates but not back into core
  2. you could just dump whatever you wanted into here and the dsl wouldn't reject anything it didn't know about

I just kinda backed into throwing this in there based on how we implemented the platform templates and didn't realize I was inadvertently stuffing non-standard content in there.

I'm up for whatever solution. But we do need some way to set defaults on suite options based on what we wanted to accomplish from a ux perspective when building inferno.healthit.gov. Does your approach require a core update? If so, we need that asap as it would block transitioning inferno.healthit.gov to use the new templates. (not a huge deal to not having this ability i guess, but it would be a loose end and i hate making backwards progress on UX before moving on to the next thing).

@arscan arscan requested a review from Jammjammjamm February 14, 2025 19:24
@arscan
Copy link
Contributor Author

arscan commented Feb 14, 2025

Updated to incorporate new version of inferno core that can properly specify defaults.

@arscan arscan merged commit 3f9dcb6 into main Feb 17, 2025
2 checks passed
@arscan arscan deleted the fi-3754-us-core-default-smart-launch branch February 17, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants